TSCBasic: normalise the drive letter spelling on Windows #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please test |
compnerd
added a commit
to compnerd/swift-package-manager
that referenced
this pull request
Jun 15, 2023
When building a project inside of VSCode with the LSP enabled, rebuilding the project would trigger a change to the mtimes of the auxiliary files resulting in an unnecessary rebuilding of targets. In conjunction with the changes to tools-support-core (swiftlang/swift-tools-support-core#422), incremental builds do not trigger a cascade of rebuilds that are unnecessary. Extracted from a patch by Ami Fischman!
tomerd
approved these changes
Jun 15, 2023
compnerd
added a commit
to compnerd/swift-package-manager
that referenced
this pull request
Jun 15, 2023
When building a project inside of VSCode with the LSP enabled, rebuilding the project would trigger a change to the mtimes of the auxiliary files resulting in an unnecessary rebuilding of targets. In conjunction with the changes to tools-support-core (swiftlang/swift-tools-support-core#422), incremental builds do not trigger a cascade of rebuilds that are unnecessary. Extracted from a patch by Ami Fischman!
|
@swift-ci please test |
tristanlabelle
approved these changes
Jun 15, 2023
compnerd
added a commit
to compnerd/swift-package-manager
that referenced
this pull request
Jun 15, 2023
When building a project inside of VSCode with the LSP enabled, rebuilding the project would trigger a change to the mtimes of the auxiliary files resulting in an unnecessary rebuilding of targets. In conjunction with the changes to tools-support-core (swiftlang/swift-tools-support-core#422), incremental builds do not trigger a cascade of rebuilds that are unnecessary. Extracted from a patch by Ami Fischman! Co-authored-by: Ami Fischman <ami@thebrowser.company>
Windows normalises the drive letter to an uppercase letter. However, some environments (e.g. nodejs) use the lower case spelling. This results in a path spelling difference which triggers a rebuild in the case that the LSP is running within VSCode. Normalise the spelling to the upper case always when building an `AbsolutePath`. Based on a patch by Ami Fischman! Co-authored-by: Ami Fischman <ami@thebrowser.company>
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
tomerd
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 15, 2023
When building a project inside of VSCode with the LSP enabled, rebuilding the project would trigger a change to the mtimes of the auxiliary files resulting in an unnecessary rebuilding of targets. In conjunction with the changes to tools-support-core (swiftlang/swift-tools-support-core#422), incremental builds do not trigger a cascade of rebuilds that are unnecessary. Extracted from a patch by Ami Fischman! Co-authored-by: Ami Fischman <ami@thebrowser.company>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows normalises the drive letter to an uppercase letter. However, some environments (e.g. nodejs) use the lower case spelling. This results in a path spelling difference which triggers a rebuild in the case that the LSP is running within VSCode.
Normalise the spelling to the upper case always when building an
AbsolutePath.Based on a patch by Ami Fischman!