Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.10] Fix platform conditions in Package.swift #432

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

MaxDesiatov
Copy link
Contributor

Cherry-pick of #431.

Current use of #if os is not compatible with cross-compilation.

Current use of `#if os` is not compatible with cross-compilation.
@MaxDesiatov MaxDesiatov added bug swift 5.10 This PR targets the 5.10 branch labels Sep 18, 2023
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) September 18, 2023 15:13
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up! It never was great but we couldn't get them in due to compatibility issues.

@MaxDesiatov MaxDesiatov merged commit 3695ee4 into release/5.10 Sep 18, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/fix-package-conditionals-5.10 branch September 18, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug swift 5.10 This PR targets the 5.10 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants