Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove redundant addclose calls (#435)" #438

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Nov 8, 2023

This reverts commit cf8a8a0.

Reverts #435.

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov MaxDesiatov self-requested a review November 8, 2023 20:11
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind elaborating on the reason for the revert?

@MaxDesiatov MaxDesiatov self-requested a review November 8, 2023 20:13
@grynspan
Copy link
Contributor Author

grynspan commented Nov 8, 2023

We are attempting to unblock CI hangs. We think this change caused the hangs, hence the revert. @tomerd

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) November 8, 2023 20:31
@tomerd tomerd disabled auto-merge November 8, 2023 22:45
@tomerd tomerd merged commit 4d539ff into main Nov 8, 2023
1 of 3 checks passed
@tomerd tomerd deleted the jgrynspan/revert-435 branch November 8, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants