Allow non-blocking file locks

[neonichu]

No description provided.

[neonichu]

swiftlang/swift-package-manager#7269
@swift-ci please test

[neonichu]

TSCBasicTests/FileSystemTests.swift:883: Fatal error: 'try!' expression unexpectedly raised an error: TSCBasic.FileSystemError(kind: TSCBasic.FileSystemError.Kind.unsupported, path: Optional(<AbsolutePath:"/tmp/TemporaryDirectory.bGFJkn/lockfile">))

Probably did something wrong in the InMemoryFileSystem implementation of non-blocking, this was only supposed to be thrown if we ask for a non-blocking lock which nothing should do.

[neonichu]

Ah no, the issue is that I didn't fully adopt InMemoryFileSystem correctly.

There seems to be something weird going on with the protocol extension and default arguments such that we call the function from the protocol extension (which throws unimplemented) rather than the one from the concrete implementation.

[neonichu]

swiftlang/swift-package-manager#7269
@swift-ci please test

[neonichu]

Changed this now such that we don't use default arguments anymore and that seems to resolve the issue.

[neonichu]

swiftlang/swift-package-manager#7269
@swift-ci please test windows

[neonichu]

swiftlang/swift-package-manager#7269
@swift-ci please test

[neonichu]

swiftlang/swift-package-manager#7269
@swift-ci please test windows

[neonichu]

2024-01-19 20:12:14.895.Test Suite 'FileSystemTests' started at 2024-01-19 20:12:14.895.
Test Case '-[TSCBasicTests.FileSystemTests testLocalReadWriteFile]' started./Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-tools-support-core/Tests/TSCBasicTests/FileSystemTests.swift:334: error: -[TSCBasicTests.FileSystemTests testLocalReadWriteFile] : XCTAssertEqual failed: ("FileSystemError(kind: TSCBasic.FileSystemError.Kind.ioError(code: 17), path: Optional(<AbsolutePath:"/">))") is not equal to ("FileSystemError(kind: TSCBasic.FileSystemError.Kind.isDirectory, path: Optional(<AbsolutePath:"/">))")Test Case '-[TSCBasicTests.FileSystemTests testLocalReadWriteFile]' failed (0.375 seconds).Test Suite 'FileSystemTests' failed at 2024-01-19 20:12:15.270.

Not sure what this is...

[neonichu]

OK, issue is present in baseline as well (https://ci.swift.org/job/pr-swift-tools-support-core-macos/359/) and I also have been seeing it locally for a while. Probably a slight behavior change between macOS versions?

[neonichu]

Fixing the test in #460

[MaxDesiatov]

swiftlang/swift-package-manager#7269
@swift-ci please test