Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSCBasic] Make init public #476

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[TSCBasic] Make init public #476

merged 1 commit into from
Jul 11, 2024

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Jun 30, 2024

This is mismatching the other init which is public.

@aciidgh
[TSCBasic] Make init public
6a9063b 
This is mismatching the other init which is public.
@aciidgh aciidgh requested review from neonichu and removed request for MaxDesiatov and bnbarham June 30, 2024 19:26
@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) July 2, 2024 11:20
@MaxDesiatov
Copy link
Contributor

@swift-ci smoke test

@shahmishal
Copy link
Member

@swift-ci test

@shahmishal
Copy link
Member

@swift-ci test Windows

1 similar comment
@jakepetroules
Copy link
Contributor

@swift-ci test Windows

@MaxDesiatov MaxDesiatov merged commit 12fa2cf into main Jul 11, 2024
3 checks passed
@MaxDesiatov MaxDesiatov deleted the ankit branch July 11, 2024 22:36
@neonichu neonichu restored the ankit branch July 24, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@neonichu neonichu Awaiting requested review from neonichu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aciidgh @MaxDesiatov @shahmishal @jakepetroules