[IRGen][runtime] Reduce object header to 8 bytes on 32-bit platforms. #12790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SR-4353, rdar://29765800
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
slavapestov
reviewed
Nov 7, 2017
lib/IRGen/GenDecl.cpp
Outdated
| @@ -3152,7 +3151,7 @@ IRGenModule::getAddrOfGlobalConstantString(StringRef utf8) { | |||
|
|
|||
| // FIXME: Big endian-ness. | |||
There was a problem hiding this comment.
You can't break all those 32-bit big endian platforms... we still care about m68k right?
There was a problem hiding this comment.
If it's not in the tests it doesn't exist.
Having said that the comment no longer applies; any endianness problems would now be inside InlineRefCountBits. I'll remove it.
|
Build failed |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-4353, rdar://29765800