Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Float80 test data on platforms that lack Float80 #15852

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

tbkka
Copy link
Contributor

@tbkka tbkka commented Apr 10, 2018

This was an oversight from PR #15474. Most of the Float80
tests were correctly compiled only on !Windows && (x86 || i386)
but I failed to mark some Float80 test data.

Fixes: Radar 39246292

This was an oversight from PR swiftlang#15474.  Most of the Float80
tests were correctly compiled only on `!Windows && (x86 || i386)`
but I failed to mark some Float80 test data.

Fixes: Radar 39246292
@tbkka
Copy link
Contributor Author

tbkka commented Apr 10, 2018

@swift-ci Please smoke test

Copy link
Contributor

@stephentyrone stephentyrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbkka
Copy link
Contributor Author

tbkka commented Apr 11, 2018

@swift-ci Please smoke test

@tbkka
Copy link
Contributor Author

tbkka commented Apr 11, 2018

(The test failure seems to have been fixed in master; let's verify that before merging.)

@tbkka tbkka merged commit dad8b73 into swiftlang:master Apr 12, 2018
@tbkka tbkka deleted the tbkka-fix-float80-in-tests branch April 12, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants