Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libSyntax] Explicitly pass source file length to c parse actions #36283

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

ahoppen
Copy link
Contributor

@ahoppen ahoppen commented Mar 4, 2021

Previously, the passed in source file was implicitly terminated by the first null character. The source file might, however, contain a null character in the middle and we shouldn't stop parsing at it.

Accompanies swiftlang/swift-syntax#261

@ahoppen ahoppen requested a review from akyrtzi March 4, 2021 17:20
@ahoppen
Copy link
Contributor Author

ahoppen commented Mar 4, 2021

swiftlang/swift-syntax#261

@swift-ci Please smoke test

Previously, the passed in source file was implicitly terminated by the
first null character. The source file might, however, contain a null
character in the middle and we shouldn't stop parsing at it.
@ahoppen ahoppen force-pushed the pr/swiftsyntax-null-char-in-file branch from 4ba380d to dd9e831 Compare March 4, 2021 21:20
@ahoppen
Copy link
Contributor Author

ahoppen commented Mar 4, 2021

swiftlang/swift-syntax#261

@swift-ci Please smoke test

@ahoppen ahoppen merged commit 9a95c64 into swiftlang:main Mar 5, 2021
@ahoppen ahoppen deleted the pr/swiftsyntax-null-char-in-file branch March 5, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants