-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Skip early-* on non-darwin hosts #68091
Conversation
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import sys
is needed in the Python files, otherwise good.
2c42a38
to
97a6f3b
Compare
Yeah, just saw the failure and re-pushed. |
@swift-ci please smoke test |
Looks like three build script tests explicitly look to see if the early swift driver output is there, so they will need to be modified too. |
97a6f3b
to
681c3c7
Compare
@swift-ci please smoke test |
These builds do not work outside of darwin currently. Rather than adding the skip to all the necessary build presets, just disable in the product instead.
681c3c7
to
8fbdae1
Compare
@swift-ci please smoke test |
@swift-ci please smoke test Linux platform |
Why was that linux smoke test failing? I didn't find that |
It's in LLVM (swiftlang/llvm-project#7307). Seems that we don't run SwiftPM tests there. |
Ah, makes sense, as that pull you reverted was just merged a couple hours ago, whereas I was looking in an LLVM checkout from this morning. |
Yeah, status job wasn't up to it yet either which initially confused me 😅 |
These builds do not work outside of darwin currently. Rather than adding the skip to all the necessary build presets, just disable in the product instead.