Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Runtime] Don't use <sys/errno.h>. #71846

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[Runtime] Don't use <sys/errno.h>. #71846

merged 1 commit into from
Feb 23, 2024

Conversation

al45tair
Copy link
Contributor

We should always be using <errno.h>, not <sys/errno.h>. The former is part of the C standard. The latter is a non-standard header that happens to be present on some systems.

rdar://123507361

@al45tair
[Runtime] Don't use <sys/errno.h>.
b2509d9 
We should always be using `<errno.h>`, not `<sys/errno.h>`.  The
former is part of the C standard.  The latter is a non-standard
header that happens to be present on some systems.

rdar://123507361
@al45tair al45tair requested a review from a team as a code owner February 23, 2024 16:34
@al45tair
Copy link
Contributor Author

@swift-ci Please smoke test

compnerd
compnerd approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this for now, but this might need to be reverted. I think that we did this because android's libc is ... shall we say different?

@al45tair
Copy link
Contributor Author

I just checked Bionic and <sys/errno.h> just does #include <errno.h>, plus this header is literally from the C standard; I honestly don't believe there's any reason to use the former.

@al45tair al45tair merged commit f24bb03 into swiftlang:main Feb 23, 2024
3 checks passed
This was referenced Feb 27, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@al45tair @compnerd @mikeash