Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos: test/IDE #75026

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Typos: test/IDE #75026

merged 1 commit into from
Aug 9, 2024

Conversation

Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Jul 7, 2024

Fix typos in test/IDE

This is one batch of many PRs fixing typos, see the tracking issue.

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a fair few typos 😅. Thanks @Sajjon, just a couple files that need to be reverted, the rest look good!

test/IDE/local_types.swift Outdated Show resolved Hide resolved
test/IDE/merge_local_types.swift Outdated Show resolved Hide resolved
@bnbarham
Copy link
Contributor

bnbarham commented Jul 8, 2024

@swift-ci please test

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test Linux

@ahoppen
Copy link
Member

ahoppen commented Jul 16, 2024

@swift-ci Please smoke test macOS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the test failure you also need to rename this file to Overlaid.h and correspondingly change OverlayTest.h to import #include <OverlayTest/Overlaid.h> instead of #include <OverlayTest/Overlayed.h>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahoppen thank you, I've done so!

@Sajjon Sajjon force-pushed the cyon_typo_batch__test__ide branch from e791236 to a80b8ae Compare August 8, 2024 17:35
@Sajjon
Copy link
Contributor Author

Sajjon commented Aug 8, 2024

@bnbarham @ahoppen @AnthonyLatsis merged main, squashed, applied suggestions. Merge ready I think, if test pass and if it looks good to you?

@ahoppen
Copy link
Member

ahoppen commented Aug 8, 2024

@swift-ci Please smoke test

@ahoppen ahoppen merged commit ffba6d1 into swiftlang:main Aug 9, 2024
3 checks passed
@Sajjon Sajjon deleted the cyon_typo_batch__test__ide branch August 9, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants