Typos: test/SILGen
#75029
Merged
Typos: test/SILGen
#75029
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conflict creeped in. |
Sajjon
force-pushed
the
cyon_typo_batch__test__SILGen
branch
from
4bbfb45 to
6ce5c67
Compare
Sajjon
requested review from
a team,
hborla,
slavapestov,
xedin,
eeckstein,
shahmishal,
artemcm,
mikeash,
al45tair,
compnerd,
ahoppen,
bnbarham,
hamishknight,
rintaro,
rjmccall,
adrian-prantl,
xymus,
kavon,
CodaFi,
DougGregor,
zoecarver,
hyp,
egorzhdan,
ktoso,
QuietMisdreavus and
AnthonyLatsis
as code owners
AnthonyLatsis
removed request for
rintaro,
adrian-prantl,
xymus,
kavon,
CodaFi,
DougGregor,
zoecarver,
hyp,
ktoso,
QuietMisdreavus,
tshortli,
beccadax and
ian-twilightcoder
Sajjon
force-pushed
the
cyon_typo_batch__test__SILGen
branch
5 times, most recently
from
4eee61e to
4359ad9
Compare
|
@AnthonyLatsis I think this is merge ready? If tests pass :) |
adrian-prantl
requested changes
Aug 8, 2024
test/SILGen/initializers.swift
Outdated
| @@ -800,7 +800,7 @@ class ThrowDerivedClass : ThrowBaseClass { | |||
| // CHECK: try_apply [[UNWRAP_FN]]({{%.*}}) : $@convention(thin) (Int) -> (Int, @error any Error), normal [[NORMAL_BB:bb[0-9]+]], error [[ERROR_BB:bb[0-9]+]] | |||
| // | |||
| // Now we emit the call to the initializer. Notice how we return self back to | |||
| // its memory locatio nbefore any other work is done. | |||
| // its memory locations nbefore any other work is done. | |||
There was a problem hiding this comment.
It really looks like this is meant to be
Suggested change
| // its memory locations nbefore any other work is done. | |
| // its memory location before any other work is done. |
no?
There was a problem hiding this comment.
@adrian-prantl thx, right you are. Fixed!
Sajjon
force-pushed
the
cyon_typo_batch__test__SILGen
branch
from
4359ad9 to
89db0cd
Compare
|
@swift-ci please smoke test |
AnthonyLatsis
approved these changes
Aug 9, 2024
adrian-prantl
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos in
test/SILGenThis is one batch of many PRs fixing typos, see the tracking issue.