Disable these tests under ASAN #75637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Do we know why they don't work under ASAN? |
|
@swift-ci Please test Linux Platform |
Yes. The test process requests large blocks of raw memory and then feeds bits of those into RemoteMirror's type and value analyses. Those blocks can span allocated & deallocated blocks in the heap, which ASAN does not like at all. An earlier version of the test process only requested the exact minimum number of bytes needed for any specific RemoteMirror request; these never include deallocated memory, so were ASAN-safe. But the new version is more than 50 times faster (when built in debug), so I think it's worth giving up ASAN validation. |
|
Here are details on the changes to the test harness: #75415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteMirror Reflection tests are incompatible with ASAN. I accidentally checked in a couple of new tests that allowed ASAN.
Resolves rdar://133012386