[test] Add explicit targets to tests depending on the default #76027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
requested review from
slavapestov,
hborla,
xedin,
rjmccall and
ktoso
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
benlangmuir
force-pushed
the
explicit-targets
branch
from
90d1a67 to
9d0b629
Compare
|
@swift-ci please test |
Add specific deployment target versions to some tests that need to test 10.x-specific behaviours and are currently depending on the default deployment target. Certain tests were only checking either the stable or unstable ABI depending on the platform the test was running. In those cases I doubled up the checks so that we would test both cases on platforms that supported it. This might use a bit of extra time on targets that only support the stable ABI, but it seemed worth it for the additional coverage in CI.
When the deployment target is newer than swift-5.4 these tests fail due to missing/incomplete support for chained fixups. rdar://134809489
benlangmuir
force-pushed
the
explicit-targets
branch
from
9d0b629 to
5d111db
Compare
|
@swift-ci please test |
tshortli
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add specific deployment target versions to some tests that need to test 10.x-specific behaviours and are currently depending on the default deployment target.
Certain tests were only checking either the stable or unstable ABI depending on the platform the test was running. In those cases I doubled up the checks so that we would test both cases on platforms that supported it. This might use a bit of extra time on targets that only support the stable ABI, but it seemed worth it for the additional coverage in CI.