Don’t serialize objcImpl members #76191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids failures where an imported member implementation is mistaken for a regular member, creating new ambiguities. Fixes rdar://134736899.
beccadax
force-pushed
the
objcimpl-serialization
branch
from
1eca67a
to
51ef44a
Compare
beccadax
requested review from
xymus,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
beccadax
changed the title
tshortli
approved these changes
Sep 3, 2024
nkcsgexi
approved these changes
Sep 4, 2024
|
Dropping this fix. It breaks indexing for objcImpl, and #76270 is a more thorough fix for the problems it was trying to solve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids failures where an imported member implementation is mistaken for a regular member, creating new ambiguities.
Fixes rdar://134736899.
WIP: Needs a test.