utils: make -BuildTargets optional in build.ps1
#76290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
CC: @hyp @hjyamauchi |
hjyamauchi
reviewed
Sep 5, 2024
| @@ -1728,7 +1723,6 @@ function Build-Dispatch([Platform]$Platform, $Arch, [switch]$Test = $false) { | |||
| -Arch $Arch ` | |||
| -Platform $Platform ` | |||
| -UseBuiltCompilers C,CXX,Swift ` | |||
There was a problem hiding this comment.
Is it okay not to keep ExperimentalTest when testing? If $Target is really dead, better to remove it from the above statement?
There was a problem hiding this comment.
No, that needs to be preserved to run the tests.
There was a problem hiding this comment.
So, we need to keep the -BuildTargets $Targets here?
hjyamauchi
reviewed
Sep 5, 2024
hjyamauchi
reviewed
Sep 5, 2024
This doesn't really add much to readability and is almost always `default`. Simply assume the default behaviour and allow callers to alter the behaviour if needed.
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please clean test macOS platfoorm |
|
@swift-ci please clean test macOS platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't really add much to readability and is almost always
default. Simply assume the default behaviour and allow callers to alter the behaviour if needed.