ASTMangler: skip mangling Copyable dependents #76293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
Typically, a conformance that is dependent on a conformance to a marker protocol never reaches this point in the compiler, where we're mangling the metadata for an opaque return type. But with the invertible protocols like Copyable, we do permit them, so we should avoid mangling Copyable as that's generally ABI incompatible with existing code. resolves rdar://135310019
kavon
force-pushed
the
ncgenerics-opaque-dependent-conformance-mangling
branch
from
7bb32a7
to
6f6a46f
Compare
|
@swift-ci smoke test |
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically, a conformance that is dependent on a conformance to a marker protocol never reaches this point in the compiler, where we're mangling the metadata for an opaque return type.
But with the invertible protocols like Copyable, we do permit them, so we should avoid mangling Copyable as that's generally ABI incompatible with existing code.
resolves rdar://135310019