Sema: Generalize heuristic in favoredOverDisjunction() #76318
Merged
+61
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Sep 6, 2024
xedin
reviewed
Sep 6, 2024
| return hasConversions(pair->second); | ||
| } else if (auto eltTy = ConstraintSystem::isSetType(structTy)) { | ||
| return hasConversions(*eltTy); | ||
| } |
There was a problem hiding this comment.
I'm a bit worried that for Array, Dictionary, Set if we are too aggressive in binding we might lose viable bindings to bridgeable types.
There was a problem hiding this comment.
We'll see what happens :) Validation tests did pass...
slavapestov
force-pushed
the
favored-over-disjunction-heuristic
branch
from
e8b1876
to
73aa029
Compare
|
@swift-ci Please smoke test |
xedin
approved these changes
Sep 9, 2024
| return hasConversions(pair->second); | ||
| } else if (auto eltTy = ConstraintSystem::isSetType(structTy)) { | ||
| return hasConversions(*eltTy); | ||
| } |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a too complex test case that was originally added in 2507a31.