Ignore inactive IfConfigDecls in SourceKit's syntax model, formatting, and placeholder expansion #76332
+44
−996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clients that need syntactic information should use SourceKit-LSP or swift-syntax.
The SourceKit code formatting tools have effectively been replaced by swift-syntax's basic formatting functionality and more full-featured formatters like swift-format and SwiftFormat. Remove the special handling of IfConfigDecl as staging for the removal of IfConfigDecl.
…nsion This is another step toward the removal of IfConfigDecl
DougGregor
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
rintaro
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients that need syntactic information, formatting, or expansion should use other tools based on the swift-syntax tree, including SourceKit-LSP, swift-format, or SwiftFormat.