[Modules] Make SubInstance spawn correctly under DirectCC1Mode #76378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
akyrtzi,
adrian-prantl and
benlangmuir
|
@swift-ci please smoke test |
adrian-prantl
approved these changes
Sep 10, 2024
artemcm
approved these changes
Sep 10, 2024
cachemeifyoucan
force-pushed
the
eng/PR-135611011
branch
from
c838575 to
ee45f6d
Compare
cachemeifyoucan
changed the title
Make sure ClangExtraArgs are inherited in the subinstance for module lookup/building when direct cc1 mode is used. This is useful for lldb, which does a slight different variant of the explicit module build that do not have swift-driver cooridination and replies on the subInstance to load swiftmodule. When such configuration is used, if DirectCC1 compile option is inherited without any extra cc1 arguments, the clang importer inside the sub-instance is actually malformed, causing the swift instance failed to be created. rdar://135611011
cachemeifyoucan
force-pushed
the
eng/PR-135611011
branch
from
ee45f6d to
a6c560b
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
|
@swift-ci please smoke test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure ClangExtraArgs are inherited in the subinstance for module lookup/building when direct cc1 mode is used. This is useful for lldb, which does a slight different variant of the explicit module build that do not have swift-driver cooridination and replies on the subInstance to load swiftmodule. When such configuration is used, if DirectCC1 compile option is inherited without any extra cc1 arguments, the clang importer inside the sub-instance is actually malformed, causing the swift instance failed to be created.
rdar://135611011