Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1] Sema: Cache Solution::getTotalMemory() #77788

Open
wants to merge 1 commit into
base: release/6.1
Choose a base branch
from
Open

[6.1] Sema: Cache Solution::getTotalMemory() #77788

wants to merge 1 commit into from

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Nov 21, 2024 •
edited
Loading

6.1 cherry-pick of #77716.

  • Description: Every time we perform the 'too complex' check we compute the sum total memory usage of all valid solutions found so far. This was showing up in performance profiles. Cache the size in the solution, since it doesn't change after construction.
  • Origination: This has always been that way.
  • Risk: Low.
  • Tested: Existing tests pass.
  • Radar: rdar://136106973.
  • Reviewed by: @hborla and @xedin

@slavapestov
Sema: Cache Solution::getTotalMemory()
4147eb9 
This is showing up in performance profiles.

Fixes rdar://136106973.
@slavapestov slavapestov requested a review from a team as a code owner November 21, 2024 20:31
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @hborla