[Dependency Scanner] Refactor the global scanning service to no longer maintain scanner cache state #77794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r maintain scanner cache state Instead, each scan's 'ModuleDependenciesCache' will hold all of the data corresponding to discovered module dependencies. The initial design presumed the possibility of sharing a global scanning cache amongs different scanner invocations, possibly even different concurrent scanner invocations. This change also deprecates two libSwiftScan entry-points: 'swiftscan_scanner_cache_load' and 'swiftscan_scanner_cache_serialize'. They never ended up getting used, and since this code has been largely stale, we are confident they have not otherwise had users, and they do not fit with this design. A follow-up change will re-introduce moduele dependency cache serialization on a per-query basis and bring the binary format up-to-date.
artemcm
force-pushed
the
RefactorGlobalDependencyScanningCache
branch
from
35f1fb0
to
ac00029
Compare
|
@swift-ci test |
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Nov 21, 2024
…serialization SwiftScan API uses This mechanism relied on serializing contents of a dependency scanner cache that included all queried scanning contexts. Instead, the scanner will move to a per-query serialization format. These API were never actually deployed and, to our knowledge, have not worked for a long time. Compiler-side change: swiftlang/swift#77794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, each scan's 'ModuleDependenciesCache' will hold all of the data corresponding to discovered module dependencies.
The initial design presumed the possibility of sharing a global scanning cache amongst different scanner invocations, possibly even different concurrent scanner invocations.
This change also deprecates two libSwiftScan entry-points:
swiftscan_scanner_cache_loadandswiftscan_scanner_cache_serialize. They never ended up getting used, and since this code has been largely stale, we are confident they have not otherwise had users, and they do not fit with this design.A follow-up change will re-introduce module dependency cache serialization on a per-query basis and bring the binary format up-to-date.