[CS] Add a narrow hack for rdar://139234188 #77802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we set `FunctionRefKind::Compound` for enum element patterns with tuple sub-patterns to ensure the member has argument labels stripped. As such, we need to account for the correct application level in `getNumApplications`. We ought to be setting the correct FunctionRefKind and properly handling the label matching in the solver though. We also ought to consider changing FunctionRefKind such that "is compound" is a separate bit from the application level. rdar://139234188
hamishknight
requested review from
hborla,
xedin and
slavapestov
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we set
FunctionRefKind::Compoundfor enum element patterns with tuple sub-patterns to ensure the member has argument labels stripped. As such, we need to account for the correct application level ingetNumApplications. We ought to be setting the correct FunctionRefKind and properly handling the label matching in the solver though. We also ought to consider changing FunctionRefKind such that "is compound" is a separate bit from the application level.Filed #77803 & #77804 to track properly fixing things here.
rdar://139234188