[CSApply] Avoid shortcutting argument conversion when parameter has a… #77816
+77
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n external property wrapper The check to see whether argument matches the parameter exactly causes two problems: prevents projected value initialized injection; and, if there are multiple parameters with property wrappers, would apply incorrect wrapper to other locations because the wrapper application index wasn't incremented. Resolves: rdar://140282980
|
@swift-ci please test |
| auto paramType = param.getOldType(); | ||
| if (argType->isEqual(paramType) && !shouldInjectWrappedValuePlaceholder) { | ||
|
|
||
| if (canShortcutConversion(argType, paramType)) { |
There was a problem hiding this comment.
I do wonder if could do away with this short-circuiting altogether, seems like too easy of a footgun and I'm not sure it's buying us much
There was a problem hiding this comment.
Yeah, that's what I was thinking as well, I just think it might be worth doing that separately...
There was a problem hiding this comment.
Oh yeah definitely, doesn't have to be this PR
…operty wrappers are used
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n external property wrapper
The check to see whether argument matches the parameter exactly causes two problems:
prevents projected value initialized injection; and, if there are multiple parameters with property
wrappers, would apply incorrect wrapper to other locations because the wrapper application
index wasn't incremented.
Resolves: rdar://140282980