[6.1] SIL: Always give @_silgen_name
forward declarations public linkage
#78188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_silgen_name
is applied to a function with no body, it is a forward declaration. It therefore must be treated as an external (public) declaration regardless of the access level it was given in source. Thestdlib/Error.swift
test case revealed that the previously incorrect linkage computation was resulting in potentially unavailable forward declarations being strongly linked when they should be weakly linked.@_silgen_name
forward declarations.@_silgen_name
forward declarations public linkage #78183@_silgen_name
forward declarations are not used much outside of the standard library and compiler test suite.