[6.1] SIL: Revert public linkage for @_silgen_name forward declarations
#78245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the stdlib build depends on `internal` functions with `@_silgen_name` getting hidden linkage in some configurations. Instead of messing with the linkage computation, just fix the `stdlib/Error.swift` test by making `setWillThrowHandler` `public` to give it the right linkage. Resolves rdar://141590619.
tshortli
changed the title
@_silgen_name forward declarations
|
@swift-ci please test |
nkcsgexi
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internalfunctions with@_silgen_namegetting hidden linkage in some configurations. Instead of messing with the linkage computation, just fix thestdlib/Error.swifttest by makingsetWillThrowHandlerpublicto give it the right linkage. Reverts SIL: Always give@_silgen_nameforward declarations public linkage #78183.@_silgen_nameforward declarations #78244