Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Sema: Diagnose @backDeployed functions with missing bodies in swiftinterfaces" #78345

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

DougGregor
Copy link
Member

Reverts #78327. It's breaking the macOS toolchain build with

/Users/ec2-user/jenkins/workspace/swift-PR-toolchain-macos/branch-main/buildbot_osx/swift-macosx-x86_64/lib/swift/xros/Swift.swiftmodule/arm64-apple-xros.private.swiftinterface:2371:2: error: '@backDeployed' requires that global function '_diagnoseUnavailableCodeReached()' have a body
 2369 | @usableFromInline
 2370 | @inline(never) internal func _diagnoseUnexpectedEnumCase<SwitchedValue>(type: SwitchedValue.Type) -> Swift.Never
 2371 | @backDeployed(before: macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0)
      |  `- error: '@backDeployed' requires that global function '_diagnoseUnavailableCodeReached()' have a body
 2372 | @usableFromInline
 2373 | @inline(never) @_semantics("unavailable_code_reached") internal func _diagnoseUnavailableCodeReached() -> Swift.Never

It's not that this PR is wrong, it's that it uncovered an existing problem.

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

@shahmishal shahmishal merged commit 55189ba into main Dec 22, 2024
8 checks passed
@shahmishal shahmishal deleted the revert-78327-back-deployed-without-body branch December 22, 2024 22:48
@shahmishal
Copy link
Member

Merged to unblock nightly toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants