Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of mysqli extension #38

Closed
michalbiarda opened this issue Sep 19, 2022 · 0 comments
Closed

Get rid of mysqli extension #38

michalbiarda opened this issue Sep 19, 2022 · 0 comments
Assignees
@michalbiarda
Labels
enhancement
Milestone
4.0.0

Comments

@michalbiarda
Copy link
Contributor

\Driver\Engines\MySql\Import\Primary is using mysqli interface, while all the other source files use PDO. Let's switch to PDO to be consistent (and to have one dependency less).
@michalbiarda michalbiarda added this to the 4.0.0 milestone Sep 19, 2022
@michalbiarda michalbiarda self-assigned this Sep 19, 2022
@michalbiarda michalbiarda moved this to In Progress in Driver Sep 19, 2022
michalbiarda added a commit that referenced this issue Sep 20, 2022
@michalbiarda
#38: Replaced Mysqli with PDO in import-s3 action
343fdd5
@michalbiarda michalbiarda moved this from In Progress to QA in Driver Sep 20, 2022
michalbiarda added a commit that referenced this issue Sep 21, 2022
@michalbiarda
Merge pull request #40 from swiftotter/38-get-rid-of-mysqli
a616e2b 
#38: Replaced Mysqli with PDO in import-s3 action
@michalbiarda michalbiarda moved this from QA to Done in Driver Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalbiarda michalbiarda

Labels
enhancement
Projects
Driver
Status: Done
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@michalbiarda