Add JSBridgedType and JSBridgedClass #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
force-pushed
the
webidl
branch
2 times, most recently
from
8b8ef8f to
f08c56c
Compare
j-f1
force-pushed
the
webidl
branch
2 times, most recently
from
ab414d7 to
000fe5b
Compare
j-f1
changed the title
j-f1
commented
Sep 15, 2020
Co-Authored-By: Yuta Saito <11702759+kateinoigakukun@users.noreply.github.com>
It’s better to use guard/if-let instead.
j-f1
commented
Sep 16, 2020
|
Please let me know when it's ready for review again 👍 |
MaxDesiatov
reviewed
Sep 17, 2020
MaxDesiatov
reviewed
Sep 17, 2020
MaxDesiatov
reviewed
Sep 17, 2020
| @@ -0,0 +1,41 @@ | |||
| /// Use this protocol when your type has no single JavaScript class. | |||
| /// For example, a union type of multiple classes or primitive values. | |||
There was a problem hiding this comment.
Could this comment give an example of such type?
There was a problem hiding this comment.
Sure. Would it be OK to link to DOMKit?
There was a problem hiding this comment.
MaxDesiatov
reviewed
Sep 17, 2020
MaxDesiatov
reviewed
Sep 17, 2020
MaxDesiatov
reviewed
Sep 17, 2020
MaxDesiatov
reviewed
Sep 17, 2020
Co-authored-by: Max Desiatov <max@desiatov.com>
MaxDesiatov
reviewed
Sep 17, 2020
MaxDesiatov
approved these changes
Sep 17, 2020
kateinoigakukun
approved these changes
Sep 18, 2020
MaxDesiatov
added a commit
to Apodini/webidl2swift
that referenced
this pull request
Dec 26, 2020
Pending the merger of swiftwasm/JavaScriptKit#26, everything needed for the output of `webidl2swift` to work will be included in the shipping version of JavaScriptKit! I made several changes to align the APIs and fixed a bug where callback protocols could not be passed as a function. * Mostly working, except for when it doesn’t (enums containing objects and primitives) JavaScriptKit a87af4e * More changes to get it finished! * Correctly set the ancestor for callback interfaces * It works! * Updates to match latest JSKit * Fix lint errors * Last updates for compatibility * Remove unnecessary fatalError in failable initializer * Record the file name tokenization errors occurred in * Address spec update that replaces void with undefined * Update Parser.swift * Fixes to asynciterable * Update Parser.swift * Update Parser.swift * Update IntermediateRepresentation.swift * Sort list of undefined types so it’s stable * Throw a fatalError when a member type is unimplemented * Add updates from review * void → undefined * Also update the other webidl files * Re-add void support * Update Sources/WebIDL/IntermediateRepresentation/Member Nodes/MethodNode.swift Co-authored-by: Max Desiatov <max@desiatov.com> Co-authored-by: Max Desiatov <max@desiatov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #21.
This allows DOMKit to build, and implements
JSBridgedClassonJSErrorandJSDate.