Add JSDate implementation with tests #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Sep 13, 2020
j-f1
reviewed
Sep 13, 2020
Co-authored-by: Jed Fox <git@twopointzero.us>
Co-authored-by: Jed Fox <git@twopointzero.us>
MaxDesiatov
commented
Sep 13, 2020
kateinoigakukun
approved these changes
Sep 14, 2020
MaxDesiatov
added a commit
that referenced
this pull request
Sep 15, 2020
Depends on #45. This is also a prerequisite for a future `JSPromise` PR with tests. I intentionally didn't match the JS API in this PR, as a special care is needed to hold a reference to the timer closure and to call `.release()` on it. Here, a user is supposed to hold a reference to a `JSTimer` instance for it to stay valid. The API is also intentionally simple, the timer is started right away, and the only way to invalidate the timer is to bring its reference count to zero. If you see a better way to manage closures passed to `setTimeout` and `setInterval`, I'd be happy to consider that. Also, Node.js and browser APIs are slightly different. `setTimeout`/`setInterval` return an object in Node.js, while browsers return a number. Fortunately, `clearTimeout` and `clearInterval` take corresponding types as their arguments, and we can store either as `JSValue`, so we can treat both cases uniformly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't 100% match the JS API, for example
getMonth/setMonthetc accessor methods are converted to properties, but the rest of it matches in the naming. I didn't expose API parts that MDN marks as non-standard or not consistent across browsers and JS implementations.