Add JSError.stack, add Error conformance #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could test that the stack is a non-empty string. |
|
Great point, I've added the check to the test. |
j-f1
approved these changes
Sep 14, 2020
kateinoigakukun
approved these changes
Sep 15, 2020
| @@ -13,6 +13,10 @@ public final class JSError { | |||
| public var name: String { | |||
| ref.name.string! | |||
| } | |||
|
|
|||
| public var stack: String { | |||
There was a problem hiding this comment.
I think it would be more safe if non-standard field is exposed as String?. For example, a new JS engine may not implement this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
stackproperty is non-standard, it's supported in all popular browser engines and Node.js.Unfortunately, because
stackvalue will be different on every machine that executes it, I'm not sure how to write a good test for it, so it currently doesn't have any tests.Also,
JSErrornow conforms toError. The main reasoning is that thePublisherprotocol in Combine requiresErrorconformance on itsFailuretype. I think in the future it would make sense to makeJSPromisecompatible with Combine, so it would be great if one could propagate errors produced byJSPromiseto other publishers/subscribers.Again,
JSPromisewill be implemented in a separate PR.