CIのSwiftバージョンを5.9.2に引き上げる #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omochi
commented
May 19, 2024
| @@ -8,22 +8,22 @@ on: | |||
|
|
|||
| jobs: | |||
| swift-test-macos: | |||
| name: Build and test on macOS with Swift ${{ matrix.swift_version }} | |||
| name: Build and test on ${{ matrix.os }} with Swift ${{ matrix.swift }}, Xcode ${{ matrix.xcode }} | |||
There was a problem hiding this comment.
将来の環境のバリエーションの追加に備え、macOS, Xcodeのバージョンもタイトルに埋めます。
omochi
commented
May 19, 2024
| timeout-minutes: 40 | ||
| runs-on: macos-13 | ||
| runs-on: ${{ matrix.os }} |
omochi
commented
May 19, 2024
| xcode: /Applications/Xcode_15.0.app/Contents/Developer | ||
| - os: macos-13 | ||
| xcode: "15.2" | ||
| swift: "5.9.2" |
There was a problem hiding this comment.
version suffixはない形で3つの定義をそろえます。
ちなみに、Xcode15.2はmacOS 13ランナーの最終環境です。
https://github.com/actions/runner-images/blob/e2a8bbc6e1ff3ea021f736e2a8589f27e681aa15/images/macos/macos-13-Readme.md
omochi
commented
May 19, 2024
| dir: "swift-5.9-release/ubuntu2204" | ||
| version: "swift-5.9-RELEASE" | ||
| dir: "swift-5.9.2-release/ubuntu2204" | ||
| version: "swift-5.9.2-RELEASE" |
|
@kateinoigakukun よろしくお願いします。 |
kateinoigakukun
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.9.2 に引き上げる
現在CartonはSwift 5.9.2 をサポート下限としています。
しかし、CIは5.9 (.0) を使っているため、下記の警告が出ています。
サポートしていない環境をテストする意味はないので、
テスト環境を5.9.2 に引き上げます。