Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

Fix enumerable array polyfill #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix enumerable array polyfill #260

wants to merge 1 commit into from

Conversation

istarion
Copy link

Previous polyfill added enumerable property to global array prototype and broke all "for .. in" cycles

jonshaffer
jonshaffer approved these changes Dec 19, 2016
View reviewed changes
Copy link

@jonshaffer jonshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pradhan-v
Copy link

+1
We can guard the for-in in our code but, this is affecting a lot of loops in the libraries that we have included.
Please merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonshaffer jonshaffer jonshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istarion @pradhan-v @jonshaffer