Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Font Awesome Icon in Menu #249

Closed
rjha999 opened this issue Mar 23, 2015 · 5 comments
Closed

Use Font Awesome Icon in Menu #249

rjha999 opened this issue Mar 23, 2015 · 5 comments

Comments

@rjha999
Copy link

rjha999 commented Mar 23, 2015

How can I use font awesome Icon in this Jquery context Menu? Please help me for this.

@AndreaCatania
Copy link

I've made 2 simple changes that allow to use FontAwesome, if will be accepted you can use it easly.

@genachka
Copy link

+1

bbrala added a commit that referenced this issue Aug 30, 2015
References:
PR#158
Issue #158
Issue #129
Issue #151
Issue #249
@bbrala
Copy link
Member

bbrala commented Aug 30, 2015

Should be able to do this with the callback option :)

@bbrala bbrala closed this as completed Aug 30, 2015
@genachka
Copy link

Seems a bit inefficient to do that via callback. Having a class(es) name
option on icon that would work as an override of default class(es) during
configuration would think to be better and easier for use.
On Aug 30, 2015 7:25 AM, "Björn Brala" notifications@github.com wrote:

Should be able to do this with the callback option :)


Reply to this email directly or view it on GitHub
#249 (comment)
.

@bbrala
Copy link
Member

bbrala commented Aug 30, 2015

Yeah it is slightly more inefficient, but not by much if you just return a icon string. By changing the way it works when you just add a string we would break old code everywhere. I rather not break backwards compatibility. The callback also serves some other purposes like making the icon dependant on the state of something else.

I'm not ready to break backwards compatibility on this. I would consider this only when there might be a redo of the way the css is structured, but i don't feel confortable doing that yet.

bbrala added a commit that referenced this issue May 24, 2016
…nd manually including font-awesome css.

See issues: #338 #328 #249
bbrala added a commit that referenced this issue May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants