-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Font Awesome Icon in Menu #249
Comments
I've made 2 simple changes that allow to use FontAwesome, if will be accepted you can use it easly. |
+1 |
Should be able to do this with the callback option :) |
Seems a bit inefficient to do that via callback. Having a class(es) name
|
Yeah it is slightly more inefficient, but not by much if you just return a icon string. By changing the way it works when you just add a string we would break old code everywhere. I rather not break backwards compatibility. The callback also serves some other purposes like making the icon dependant on the state of something else. I'm not ready to break backwards compatibility on this. I would consider this only when there might be a redo of the way the css is structured, but i don't feel confortable doing that yet. |
How can I use font awesome Icon in this Jquery context Menu? Please help me for this.
The text was updated successfully, but these errors were encountered: