Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invisible items not skipped when using up and down arrows #348

Closed
arashdalir opened this issue Feb 11, 2016 · 2 comments
Closed

Invisible items not skipped when using up and down arrows #348

arashdalir opened this issue Feb 11, 2016 · 2 comments

Comments

@arashdalir
Copy link
Contributor

It seems like the menu items which are marked as invisible (visible: false) are still counted when the up and down buttons are used to control the menu. If there is an invisible item (#2) between two visible items(#1 and #3), the focus goes from #1 to #2 (display:none) to #3.
@bbrala bbrala closed this as completed in 88a45be Feb 14, 2016
bbrala added a commit that referenced this issue Feb 14, 2016
@bbrala
When you call the nextitem / previtem right after the creation of the…
5cf5c69 
… menu, it fails since it is not rendered yet. This check might need to be different. Reopens #348
@arashdalir
Copy link
Contributor Author

so, this problem has been fixed in 8e18de4. Thanks :)

@bbrala
Copy link
Member

bbrala commented Feb 15, 2016

Hehe sorry forgot to comment here. Yeah I made a fix but need to check if nothing breaks since a test is falling. I was called away from my computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arashdalir @bbrala