Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow '0' as id in ItemDocumentBuilder #27

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Oct 24, 2018

Description

Allow '0' as id in ItemDocumentBuilder.

Motivation and context

Id '0' was not possible when using the ItemDocumentBuilder, but the spec does not forbid this: https://jsonapi.org/format/#document-resource-object-identification

How has this been tested?

Tested using (added) unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo requested a review from vblinden October 24, 2018 10:26
@JaZo JaZo merged commit 871ae18 into master Oct 24, 2018
@JaZo JaZo deleted the bugfix/item-document-builder-with-id-0 branch October 24, 2018 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants