Remove art4/json-api-client dependency #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed the art4/json-api-client dependency and implemented the validation in this package.
Motivation and context
The dependency had some major changes and it was a lot of work to update the package. We can easily validate and parse the json ourselves, so I just removed the dependency. Besides, this dependency gave licensing issues because it is licensed under GPL. This closes #56.
N.B. I consider this a bugfix as the public API isn't changed.
How has this been tested?
Tested with existing and new unit tests.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.