Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove art4/json-api-client dependency #58

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Jul 18, 2019

Description

I removed the art4/json-api-client dependency and implemented the validation in this package.

Motivation and context

The dependency had some major changes and it was a lot of work to update the package. We can easily validate and parse the json ourselves, so I just removed the dependency. Besides, this dependency gave licensing issues because it is licensed under GPL. This closes #56.

N.B. I consider this a bugfix as the public API isn't changed.

How has this been tested?

Tested with existing and new unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

The dependency had some major changes and it was a lot of work to update
the package. We can easily validate and parse the json ourselves, so I
just removed the dependency. Besides, this dependency gave licensing
issues because it is licensed under GPL.
@JaZo JaZo requested a review from HendrikN July 18, 2019 10:03
@JaZo
Copy link
Member Author

JaZo commented Jul 19, 2019

Scrutinizer says the overall code quality decreased because of all the conditions, but I don't see how I can change that as they are all justified.

@JaZo JaZo merged commit d5cfd4d into master Jul 22, 2019
@JaZo JaZo deleted the feature/remove-art4-json-api-client branch July 22, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update art4/json-api-client dependency
2 participants