Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exlude some rows feature #23

Merged
merged 6 commits into from
Apr 30, 2020
Merged

Conversation

samberrry
Copy link
Contributor

@samberrry samberrry commented Apr 26, 2020

Description

I added a feature to the search query logic

Motivation and context

I had a requirement to not get some indexable records (my models which use Indexable). In my scenario think about a blog system which my model (the post model) has an is_published column. If this column is false is must not get anything search result about that post. I want it to be handled when I make query not after I get results from search and pruning it.

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@samberrry
Copy link
Contributor Author

Hello,
I cant understand the error for CI build process!

@JaZo
Copy link
Member

JaZo commented Apr 28, 2020

@vhessam the CI failure is caused by code style errors. Please run composer fix-style and amend the results in your commit.

@samberrry
Copy link
Contributor Author

OK I'll do it

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@samberrry
Copy link
Contributor Author

I updated readme file with an example. Please check it out .

@bbrala bbrala merged commit 6c0e5da into swisnl:master Apr 30, 2020
@bbrala
Copy link
Member

bbrala commented Apr 30, 2020

Thanks! Merged :)

@samberrry
Copy link
Contributor Author

@bbrala many thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants