Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel 11 #19

Merged
merged 6 commits into from
May 15, 2024
Merged

Conversation

pjotrvdh
Copy link

Description

This pull request updates the version numbers in the composer.json file to reflect the latest stable releases of the dependencies.

Motivation and context

I was updating a project to Laravel 11 and was unable to because of missing versions.

How has this been tested?

I was able to successfully update my project

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@pjotrvdh pjotrvdh requested a review from JaZo May 13, 2024 09:32
@tommie1001
Copy link

@JaZo wellicht kunnen we 7.4 weghalen met een nieuwe versie?

@pjotrvdh pjotrvdh force-pushed the feature/bump-versions branch from 0061397 to 87dab54 Compare May 14, 2024 15:06
@pjotrvdh pjotrvdh force-pushed the feature/bump-versions branch from 87dab54 to cdefe6b Compare May 14, 2024 15:08
@JaZo
Copy link
Member

JaZo commented May 14, 2024

@JaZo wellicht kunnen we 7.4 weghalen met een nieuwe versie?

The tests for 8.2 and 8.3 were failing, so that wasn't the problem. Although I'm okay with removing support for 7.4 if it's blocking.

@tommie1001
Copy link

Perhaps not blocking, but I think its better to release new versions for the current supported php versions instead of giving support for unsupported php versions

@JaZo JaZo changed the title Build: bump versions Add support for Laravel 11 May 15, 2024
@JaZo JaZo merged commit 61db590 into swisnl:master May 15, 2024
10 of 11 checks passed
@JaZo
Copy link
Member

JaZo commented May 15, 2024

As long as it doesn't get in our way I usually leave it so we don't force anyone to update, but if it gets in the way at all I remove it immediately. @Rocksheep is working on a new feature that requires PHP 8 features (#18), so he removed 7.4 support there. So eventually support will be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants