Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use configured column name instead of key to retrieve example data #20

Conversation

maartenpaauw
Copy link

Description

Given the following configured schema filters, this spec generator package tries to retrieve example data from the model using the event key name which is incorrect because a column name is provided.

public function filters(): array
{
    return [Where::make(name: 'event', column: 'event_class')];
}

Motivation and context

Without this fix, it's impossible to generate specs when using column configuration.

How has this been tested?

Tested by running generate command.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Co-authored-by: Patrick Falize <patrick.falize@npo.nl>
@JaZo JaZo requested a review from Rocksheep October 10, 2024 13:53
@maartenpaauw
Copy link
Author

I'm not sure why the code style action is failing? 🤔

It says: GitHub Actions has encountered an internal error when running your job.. Maybe @JaZo or @Rocksheep can restart this action?

@JaZo
Copy link
Member

JaZo commented Oct 10, 2024

I've restarted it, but it's failing because PHP-CS-Fixer has some new rules. We should best fix that in master.

@JaZo
Copy link
Member

JaZo commented Oct 10, 2024

I've fixed the code style in master, so if you rebase the check should pass!

@JaZo JaZo merged commit 853052b into swisnl:master Oct 10, 2024
10 of 11 checks passed
@maartenpaauw maartenpaauw deleted the bugfix/use-configured-column-name-to-retrieve-example-data branch October 10, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants