-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to allow for Laravel 11 and Laravel JSON:API v5 support #24
Conversation
Actually, a question: should I'll update this PR when I have an answer on laravel-json-api/hashids#2 |
Thank you for contributing to the project. I see that laravel-json-api/hashids#2 has been merged. Kan you update the PR to use the new version? |
@Rocksheep thanks for the ping! now that upstream has been properly versioned, there's new requirements that ultimately demand newer versions of phpunit I've now sorted out the deprecation errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR. I've added my feedback as we need a couple of small changes. I hope that you have the time to process it the feedback.
@Rocksheep sorry about the delay, that's sorted now |
@Westie I updated your PR to fix the tests and fix a merge conflict. Thanks again for making this PR. It will be merged now. |
Version 0.8.0 which contains this change has just been released! 🎉 |
Description
Updates
composer.json
to allow for Laravel 11 and JSON:API v5.x support. Also includes bump to support PHPUnit 10 and/or PHPUnit 11 as required.Motivation and context
Needed for Laravel 11 support.
How has this been tested?
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!