Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic for converting GET-params to a filename #2

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Sep 5, 2018

Description

I replaced Stringy->slugify with a less destructive method and we don't replace = and & characters.

Motivation and context

The current logic for converting the GET-params to a filename is too strict and can lead to collisions. This fixes #1 by making the logic looser and collisions less likely as discussed.

Please note that this is a breaking change!

How has this been tested?

Tested using updated and existing tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo merged commit 5d49aa2 into master Sep 5, 2018
@JaZo JaZo deleted the issue/1 branch September 5, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting possible mock file paths can result in a collision
1 participant