Feature/32591 authenticate #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
develop branch workflow
…error-responses use actual problem json in wiremock responses
publish release and develop changes. Updates logback configuration
Snapshot increase
…oll source directories (as before) in case events are not available
…stem-events-instead-of-polling-in-filesystems-that-support-events #37649 use filesystem events to trigger file upload when available, p…
…pload once at startup; per-execution polling logs are now on level DEBUG
…stem-events-instead-of-polling-in-filesystems-that-support-events #37649 only log which directories are being polled for documents to u…
…fest-after-main-class-renaming Fixed wrong name of start class in SpringBoot uber jar
Release/3.1.0
Release/3.1.1
…n-implementation-as-a-temp-fix Disable check for noop span implementation.
Release/3.1.2
…media-type #37791 cdr-api no longer requires the version as part of the content …
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/kotlin/com/swisscom/health/des/cdr/clientvm/msal4j/LocalhostHttpClient.kt
Fixed
Show fixed
Hide fixed
rsteppac
requested changes
Oct 31, 2024
src/main/kotlin/com/swisscom/health/des/cdr/clientvm/config/CdrClientContext.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/swisscom/health/des/cdr/clientvm/handler/FileHandlingBase.kt
Outdated
Show resolved
Hide resolved
| this[AZURE_TRACE_ID_HEADER] = traceId | ||
| this.build() | ||
| // TODO: Remove this check once the token is required | ||
| val accessToken = if(cdrClientConfig.idpCredentials.tenantId != DEFAULT_TENANT_ID) { |
There was a problem hiding this comment.
You could return the token string from getAccessToken(), use an empty string in the else case and then test for isNotBlank to decide whether you should add the bearer token authZ header?
There was a problem hiding this comment.
But that would mean that we called the token service with some wrong data. If we already know that we don't want to call it then I'd rather not do it.
src/main/kotlin/com/swisscom/health/des/cdr/clientvm/handler/FileHandlingBase.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/swisscom/health/des/cdr/clientvm/msal4j/LocalhostHttpClient.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/com/swisscom/health/des/cdr/clientvm/CdrClientApplicationTest.kt
Dismissed
Show dismissed
Hide dismissed
src/test/kotlin/com/swisscom/health/des/cdr/clientvm/CdrClientApplicationTest.kt
Dismissed
Show dismissed
Hide dismissed
rsteppac
previously approved these changes
Nov 6, 2024
rsteppac
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.