Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Enum in Matrimonial Property Scheme - Rel 4.0 final solution #135

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions mortgageAPI.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@
post:
summary: Place a new mortgage application (serves as dossier)
description: |
Place a new application including all necessary information about the property and applicant's financial situation.

Check warning on line 336 in mortgageAPI.yaml

View workflow job for this annotation

GitHub Actions / pr-yaml-lint

336:124 [trailing-spaces] trailing spaces
**Note that in the case where the FI needs additional information on the property, the error response 400 must contain the minimum required JSON object (PropertyObject) as detail**.
tags:
- Mortgage Application
Expand Down Expand Up @@ -1756,6 +1756,13 @@
- other
description: The class of property (Main residence, second residence, rented).
example: main_residence
matrimonialPropertyScheme:
type: string
example: separateEstate
enum:
- jointEstate
- separateEstate
- contributionToJointlyAcquiredProperty
floorPlan:
type: string
enum:
Expand Down Expand Up @@ -2709,14 +2716,13 @@
- registered-partnership
- legally-separated
- partnership-dissolved
matrimonialPropertyScheme:
PropertyOwner:
type: string
example: separateEstate
example: 'yes'
enum:
- jointEstate
- separateEstate
- contributionToJointlyAcquiredProperty
- none
- yes

Check warning on line 2723 in mortgageAPI.yaml

View workflow job for this annotation

GitHub Actions / pr-yaml-lint

2723:19 [truthy] truthy value should be one of [false, true]
- no

Check warning on line 2724 in mortgageAPI.yaml

View workflow job for this annotation

GitHub Actions / pr-yaml-lint

2724:19 [truthy] truthy value should be one of [false, true]
description: Is the applicant owner of the financed property? Yes/No
jobSituation:
type: string
example: employed
Expand Down Expand Up @@ -3507,4 +3513,4 @@
application/problem+json:
schema:
$ref: '#/components/schemas/commonErrorResponse'
# ---- End Responses - Standard

Check warning on line 3516 in mortgageAPI.yaml

View workflow job for this annotation

GitHub Actions / pr-yaml-lint

3516:3 [comments-indentation] comment not indented like content