Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwaggerEditor link to Readme #143

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Add SwaggerEditor link to Readme #143

merged 2 commits into from
Jun 19, 2023

Conversation

dkoeni
Copy link
Contributor

@dkoeni dkoeni commented Jun 12, 2023

update Readme

README.md Outdated
@@ -9,3 +9,6 @@
[![GitHub license](https://img.shields.io/github/license/swissfintechinnovations/ca-mortgage)](https://github.com/swissfintechinnovations/ca-mortgage/blob/main/LICENSE)

This is the official SFTI repo for the mortgage API. Documentations may be found in the [Wiki](https://github.com/swissfintechinnovations/ca-mortgage/wiki).

We refer to the SwaggerEditor for a graphical representation and source-file based documentation of the latest API state:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest the following wording instead: "An easy-to-read representation of the Mortgage API is accessible via the following link (please note that if you click on the following link, you will leave GitHub unless you use your browser's "open link in new tab/window" feature):"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juergen-petry I'd suggest not to mention any redirection comments. I hope everyone knows how links work these days and it distracts from the essential. Do you agree? If yes, I'd adopt your suggestion.

rolfwagner
rolfwagner previously approved these changes Jun 16, 2023
Copy link
Contributor

@rolfwagner rolfwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dkoeni dkoeni merged commit 873add9 into main Jun 19, 2023
@dkoeni dkoeni deleted the update-readme branch June 19, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants