-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
@@ -1,5 +1,5 @@ | |||
# Base image containing dependencies used in builder and final image | |||
FROM swissgrc/azure-pipelines-dotnet:6.0.407 AS base | |||
FROM ghcr.io/swissgrc/azure-pipelines-dotnet:6.0.407 AS base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked if Renovate is capable of handling updates from ghcr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find anything specific in the docs,
but renovate itself has base images with ghcr.io registry (see renovatebot/docker-renovate-full#1560)
I guess as long as the registry is public, no further steps are required.
@pascalberger I couldn't change the badge to ghcr.io as it's not yet implemented. See badges/shields#5594 |
README.md
Outdated
| Tag | Description | Base Image | Azure CLI | Size | | ||
|----------|----------------------------------------------------------------------------------------------------------|-------------------------------------------------|-----------|-----------------------------------------------------------------------------------------------------------------------------------| | ||
| latest | Latest stable release (from `main` branch) | swissgrc/azure-pipelines-dotnet:6.0.407 | 2.46.0 | ![Docker Image Size (tag)](https://img.shields.io/docker/image-size/swissgrc/azure-pipelines-azurecli/latest?style=flat-square) | | ||
| unstable | Latest unstable release (from `develop` branch) | ghcr.io/swissgrc/azure-pipelines-dotnet:6.0.407 | 2.46.0 | ![Docker Image Size (tag)](https://img.shields.io/docker/image-size/swissgrc/azure-pipelines-azurecli/unstable?style=flat-square) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't change image name to a specific repository, since we publish to multiple registries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the README.md changes
No reason to change badge IMHO since we still continue to publish to Docker Hub and the badge is still valid |
49c4e74
to
0165613
Compare
Base Image is now available on both Docker Hub and ghcr.io.