Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Switch base image to ghcr.io #83

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Switch base image to ghcr.io #83

merged 1 commit into from
Mar 30, 2023

Conversation

Xzelsius
Copy link
Contributor

Base Image is now available on both Docker Hub and ghcr.io.

@@ -1,5 +1,5 @@
# Base image containing dependencies used in builder and final image
FROM swissgrc/azure-pipelines-dotnet:6.0.407 AS base
FROM ghcr.io/swissgrc/azure-pipelines-dotnet:6.0.407 AS base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if Renovate is capable of handling updates from ghcr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find anything specific in the docs,
but renovate itself has base images with ghcr.io registry (see renovatebot/docker-renovate-full#1560)

I guess as long as the registry is public, no further steps are required.

@Xzelsius Xzelsius marked this pull request as ready for review March 30, 2023 10:52
@Xzelsius Xzelsius requested a review from a team March 30, 2023 10:52
@Xzelsius
Copy link
Contributor Author

@pascalberger I couldn't change the badge to ghcr.io as it's not yet implemented. See badges/shields#5594

@Xzelsius Xzelsius requested a review from pascalberger March 30, 2023 10:55
README.md Outdated
| Tag | Description | Base Image | Azure CLI | Size |
|----------|----------------------------------------------------------------------------------------------------------|-------------------------------------------------|-----------|-----------------------------------------------------------------------------------------------------------------------------------|
| latest | Latest stable release (from `main` branch) | swissgrc/azure-pipelines-dotnet:6.0.407 | 2.46.0 | ![Docker Image Size (tag)](https://img.shields.io/docker/image-size/swissgrc/azure-pipelines-azurecli/latest?style=flat-square) |
| unstable | Latest unstable release (from `develop` branch) | ghcr.io/swissgrc/azure-pipelines-dotnet:6.0.407 | 2.46.0 | ![Docker Image Size (tag)](https://img.shields.io/docker/image-size/swissgrc/azure-pipelines-azurecli/unstable?style=flat-square) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't change image name to a specific repository, since we publish to multiple registries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the README.md changes

@pascalberger
Copy link
Member

@pascalberger I couldn't change the badge to ghcr.io as it's not yet implemented. See badges/shields#5594

No reason to change badge IMHO since we still continue to publish to Docker Hub and the badge is still valid

@Xzelsius Xzelsius force-pushed the feature/switch-to-ghcr branch from 49c4e74 to 0165613 Compare March 30, 2023 11:04
@Xzelsius Xzelsius merged commit 9fa6fc5 into develop Mar 30, 2023
@Xzelsius Xzelsius deleted the feature/switch-to-ghcr branch March 30, 2023 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants