Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action and script to allow for theme choice #9

Merged
merged 9 commits into from
Nov 1, 2023

Conversation

joemcgill
Copy link
Contributor

This PR makes a few updates to the GitHub action and related CLI script to allow someone running either workflow determine the individual theme that is being tested, rather than hard coding both the twentytwentyone and twentytwentythree themes and running them in sequence, which we've found causes the benchmarks for the second theme to be effected by changes to the environment during tests of the first theme.

GitHub action workflow
The GH action has been updated so that the twentytwentyfour theme is installed on the environments and the workflow can be run by choosing either twentytwentyone, twentytwentythree, or twentytwentyfour from the UI:

workflow dropdown

CLI script
The CLI script has been modified so the third parameter is now the theme slug that you want to test. Example:

./run.sh https://wordpress.org/wordpress-6.3.2.zip https://wordpress.org/wordpress-6.4-RC2.zip twentytwentythree

Additionally, the environment vars are updated to turn off Cron (DISABLE_WP_CRON: true) while running benchmarks to keep scheduled tasks from effecting the results during benchmarking runs.

@swissspidy
Copy link
Owner

Additionally, the environment vars are updated to turn off Cron (DISABLE_WP_CRON: true) while running benchmarks to keep scheduled tasks from effecting the results during benchmarking runs.

There's a lot more to be done in this regard (cleanup / reset / reducing variance), e.g. disabling external HTTP calls. But it's a start 👍

@swissspidy swissspidy merged commit 13618c0 into swissspidy:main Nov 1, 2023
2 checks passed
@joemcgill joemcgill deleted the test/theme-choice branch November 1, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants