Update action and script to allow for theme choice #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few updates to the GitHub action and related CLI script to allow someone running either workflow determine the individual theme that is being tested, rather than hard coding both the
twentytwentyone
andtwentytwentythree
themes and running them in sequence, which we've found causes the benchmarks for the second theme to be effected by changes to the environment during tests of the first theme.GitHub action workflow
The GH action has been updated so that the
twentytwentyfour
theme is installed on the environments and the workflow can be run by choosing eithertwentytwentyone
,twentytwentythree
, ortwentytwentyfour
from the UI:CLI script
The CLI script has been modified so the third parameter is now the theme slug that you want to test. Example:
Additionally, the environment vars are updated to turn off Cron (
DISABLE_WP_CRON: true
) while running benchmarks to keep scheduled tasks from effecting the results during benchmarking runs.