-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bundle #47
add bundle #47
Conversation
Moved to main thread. |
The main concern with using fieldalignment is that it removes comments. This occurs presumably due to golang/go#20744 which prevents the tool from maintaining comment positions. One way to solve this is to add an additional step to the
|
The following structs have their field comments removed.
|
The following structs have their field comments removed.
|
exit code 3 may indicate that the tool was unable to align everything
refactor generator error messages
Failure explained by https://stackoverflow.com/questions/54090404/what-is-causing-this-data-race |
This pull request adds the
disgo.go
bundle with fieldalignment.Compiled Binary Size
Does adding a copy of
wrapper
(the bundle) make the binary larger? No. To start, the number is lower than stated because I forgot to import the cost of importingfmt
. In addition, the compiler will ignore certain packages that remain unused. Such that importingfmt
anddisgo
totals 6.5 MB. Importingdisgo
andwrapper
only increases the amount slightly more. So either the method to achieve this measurement is extremely wrong, ordisgo
only adds 4.7 MB (rounded up to 5 MB).The
command
example is only 10.8 MB despite importing a bit more thanfmt
anddisgo
.