This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Added support for 5.6|5.7 laravel|lumen. #178
Merged
+2,639
−802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes old laravel|lumen versions. Added support for 5.6|5.7 laravel|lumen. Added to config support for hot reload (Next PR).
# Conflicts: # src/Coroutine/PDOStatement.php # src/HttpServiceProvider.php # src/Server/Manager.php # src/Server/Sandbox.php # src/Task/SwooleTaskQueue.php # tests/Server/ManagerTest.php
Removes old laravel|lumen versions. Added support for 5.6|5.7 laravel|lumen. Added to config support for hot reload (Next PR).
|
Hi @fractalzombie , Thanks a lot for your awesome pull request. I'd like to discuss some coding style stuff with you if you don't mind.
That would be great if you can fix these styles. However, it's not mandatory. Just let me know when you complete all your pull requests. I can fix them by myself after that. :) |
|
ok, i will push fixes after work. |
|
Ok, I fix it and push. You can merge. I working on new PR, but don't know when it will be ready. |
|
That's totally fine. Thanks again for your awesome PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring.
Removes old laravel|lumen versions.
Added support for 5.6|5.7 laravel|lumen.
Added to config support for hot reload (Next PR).