This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 391
Add Gzip support on response chunk mode #456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any idea when this will be approved? |
I'm still reviewing it |
I will add more test case to increase coverage today, at least for my code. |
Is there anything I can do to improve the PR to help you @Arkanius approve it? |
Thank you @hezachary ! I think that is ok! I'm planning to release it at this week |
@hezachary it's now release as v2.7.0 Thanks for your support! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swoole does not support compress on chunk mode, related document: https://wiki.swoole.com/#/http_server?id=http_compression
The patch provide gzip for such needs.
A example is AWS load balance in many cases can replace server like apache or nginx. However, ALB does not provide compression. Once swoole in chunk mode, there almost no other choice but to add a web server in between.
gzip
optionhttp_compression = true
gzencode
is installed